-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor get_gas_spent #1051
Refactor get_gas_spent #1051
Conversation
c20288cPallet tests (values are in nanosegconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
2ac415bPallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
7f6bc03Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
4f4407ePallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
c2c4cf1Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
88c16b5Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
|
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
- Coverage 74.42% 74.13% -0.30%
==========================================
Files 90 90
Lines 8786 8675 -111
==========================================
- Hits 6539 6431 -108
+ Misses 2247 2244 -3
Continue to review full report at Codecov.
|
adjust to the change
into gshep/issue-1049 Conflicts: pallets/gear/src/mock.rs pallets/gear/src/tests.rs
into gshep/issue-1049
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🔥
We've discussed returning an error when trying to send gas to the user mailbox but as I see you calc it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see such improvements 👍
The last thing to do is just wait for @osipov-mit review and PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
into gshep/issue-1049 Conflicts: pallets/usage/src/offchain.rs
Resolves #1049
@gear-tech/dev
Release Notes:
get_gas_spent
was renamed tocalculate_gas_info
to render its new logic: more details about required gas for execution are now provided by the function. New function argument added that controls whether execution of secondary programs may result in a trap. The function calculates gas amount with greater precision.